Skip to content

Use run_subtests utility in FSDP test_state_dict_save_load_flow test #95090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use run_subtests utility in FSDP test_state_dict_save_load_flow test #95090

wants to merge 1 commit into from

Conversation

kiersten-stokes
Copy link
Contributor

@kiersten-stokes kiersten-stokes commented Feb 17, 2023 •
edited
Loading

Converts the single-instance of self.subTest in test_fsdp_state_dict.py to use the run_subtests utility.

Related: #84171

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 17, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95090

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3ada9ff:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kiersten-stokes kiersten-stokes marked this pull request as ready for review February 17, 2023 23:08
@kiersten-stokes
Copy link
Contributor Author

kiersten-stokes commented Feb 17, 2023 •
edited
Loading

Looking at other PRs opened in this time frame and at the run logs, I believe the test failures are unrelated

awgu
awgu approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awgu
Copy link
Collaborator

awgu commented Feb 21, 2023

@pytorchbot rebase -s

@awgu awgu added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 21, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased use-run_subtests onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout use-run_subtests && git pull --rebase)

@awgu
Copy link
Collaborator

awgu commented Feb 21, 2023

@pytorchbot merge

@awgu awgu added the release notes: distributed (fsdp) release notes category label Feb 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@kiersten-stokes @cyyever
Use run_subtests utility in FSDP test_state_dict_save_load_flow t…
af72d93 
…est (#95090)

Converts the single-instance of `self.subTest` in `test_fsdp_state_dict.py` to use the `run_subtests` utility.

Related: #84171

Pull Request resolved: pytorch/pytorch#95090
Approved by: https://github.com/awgu
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "Use run_subtests utility in FSDP `test_state_dict_save_load…
846b51a 
…_flow` test (pytorch#95090)"

This reverts commit b0f22f8.
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@kiersten-stokes @jhavukainen
Use run_subtests utility in FSDP test_state_dict_save_load_flow t…
6a5470b 
…est (pytorch#95090)

Converts the single-instance of `self.subTest` in `test_fsdp_state_dict.py` to use the `run_subtests` utility.

Related: pytorch#84171

Pull Request resolved: pytorch#95090
Approved by: https://github.com/awgu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgu awgu awgu approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: distributed (fsdp) release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiersten-stokes @awgu @pytorchmergebot @pytorchbot