[MPS] Disallow reshape in slice #95905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95905
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 41c716a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kulinseth
approved these changes
Mar 3, 2023
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 3, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes pytorch#95883 Pull Request resolved: pytorch#95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth
This was referenced Mar 3, 2023
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 3, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes pytorch#95883 Pull Request resolved: pytorch#95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth
malfet
pushed a commit
that referenced
this pull request
Mar 3, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes #95883 Pull Request resolved: #95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth Co-authored-by: Denis Vieriu <dvieriu@apple.com>
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes pytorch/pytorch#95883 Pull Request resolved: pytorch/pytorch#95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes pytorch/pytorch#95883 Pull Request resolved: pytorch/pytorch#95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth
ydwu4
pushed a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 10, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes pytorch#95883 Pull Request resolved: pytorch#95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes pytorch#95883 Pull Request resolved: pytorch#95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
Disallow reshapes for arrayViews. Current code allows a base shape of `[2, 4, 256]` to be sliced into `[4, 1, 256]` (view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out. Fixes pytorch#95883 Pull Request resolved: pytorch#95905 Approved by: https://github.com/razarmehr, https://github.com/kulinseth Co-authored-by: Denis Vieriu <dvieriu@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow reshapes for arrayViews.
Current code allows a base shape of
[2, 4, 256]to be sliced into[4, 1, 256](view's shape) - which is not possible. Slicing a smaller dimension into a bigger one will always error out.Fixes #95883