Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Apr 14, 2023

Mostly s/@master/@main in numerous .yml files

@malfet malfet requested a review from a team as a code owner April 14, 2023 22:42
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99210

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5d8419e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 14, 2023
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI would probably work, but a bunch of queries on Rockset definitely need to be updated eventually. HUD could be broken otherwise

@@ -308,7 +308,7 @@ Note that the Windows Python wheels are still built in conda environments. Some

* These should all be consolidated
* These must run on all OS types: MacOS, Linux, and Windows
* These all run smoke tests at the moment. They inspect the packages some, maybe run a few import statements. They DO NOT run the python tests nor the cpp tests. The idea is that python tests on master and PR merges will catch all breakages. All these tests have to do is make sure the special binary machinery didn’t mess anything up.
* These all run smoke tests at the moment. They inspect the packages some, maybe run a few import statements. They DO NOT run the python tests nor the cpp tests. The idea is that python tests on mainand PR merges will catch all breakages. All these tests have to do is make sure the special binary machinery didn’t mess anything up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@malfet malfet force-pushed the malfet/prep-for-default-branch-migration branch from 2fe69a7 to 7be01bb Compare April 17, 2023 00:42
@malfet malfet force-pushed the malfet/prep-for-default-branch-migration branch from 7be01bb to 0ef6faa Compare April 17, 2023 01:05
@malfet malfet force-pushed the malfet/prep-for-default-branch-migration branch from 0ef6faa to 5d8419e Compare April 17, 2023 01:33
@malfet malfet merged commit 2418b94 into main Apr 17, 2023
@malfet malfet deleted the malfet/prep-for-default-branch-migration branch April 17, 2023 01:48
@justinchuby
Copy link
Collaborator

Need to change

merge_base_with = "origin/master"
as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants