Skip to content

Differentiable PPOLoss for IRL #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2022
Merged

Differentiable PPOLoss for IRL #240

merged 3 commits into from
Jul 8, 2022

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Jun 30, 2022 •
edited
Loading

Usage:

>>> floss_fn, params, buffers = functorch.make_functional_with_buffers(loss_fn)
>>> loss = floss_fn(params, buffers, td)

See tests for more context.

( I made _LossModule public -- this can be moved to another PR )

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2022
@vmoens vmoens marked this pull request as draft June 30, 2022 20:33
shagunsodhani
shagunsodhani reviewed Jul 8, 2022
View reviewed changes
@vmoens vmoens added the enhancement New feature or request label Jul 8, 2022
@vmoens vmoens changed the title [WIP] Differntiable PPOLoss for IRL Differntiable PPOLoss for IRL Jul 8, 2022
@vmoens vmoens marked this pull request as ready for review July 8, 2022 14:50
shagunsodhani
shagunsodhani approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@shagunsodhani shagunsodhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vmoens vmoens changed the title Differntiable PPOLoss for IRL Differentiable PPOLoss for IRL Jul 8, 2022
@vmoens vmoens merged commit d48534b into main Jul 8, 2022
@vmoens vmoens deleted the differentiable_ppo branch July 8, 2022 17:25
@Benjamin-eecs Benjamin-eecs linked an issue Jul 19, 2022 that may be closed by this pull request
[Feature Request] Objectives modules refactoring #117
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shagunsodhani shagunsodhani shagunsodhani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Objectives modules refactoring
3 participants
@vmoens @shagunsodhani @facebook-github-bot