Skip to content

Added test for RewardRescale transform #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2022
Merged

Added test for RewardRescale transform #252

merged 1 commit into from
Jul 7, 2022

Conversation

nicolas-dufour
Copy link
Contributor

PR for reward rescale tranform tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2022
@vmoens vmoens added the Tests Incomplete or broken unit tests label Jul 7, 2022
vmoens
vmoens approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Nicolas!

@vmoens vmoens merged commit 0043d57 into pytorch:main Jul 7, 2022
@nicolas-dufour nicolas-dufour deleted the rescale-reward-test branch September 16, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-dufour @vmoens @facebook-github-bot