Skip to content

Conversation

srikanthmg85
Copy link
Contributor

Description

Added unit test for Binarize reward

Motivation and Context

Address issue [https://github.com//issues/87]

Types of changes

What types of changes does your code introduce? Remove all that do not apply:
Unit test for existing functionality

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [ x] I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this,
Almost there!

@vmoens vmoens changed the title Added test for BinarizeReward [Test] tests for BinarizeReward Jul 20, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens added the Tests Incomplete or broken unit tests label Jul 20, 2022
@vmoens vmoens linked an issue Jul 20, 2022 that may be closed by this pull request
@vmoens vmoens merged commit 0dd4594 into pytorch:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unittests for binarized reward
3 participants