Skip to content

[BugFix] In-place __setitem__ for SubTensorDict #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2022
Merged

[BugFix] In-place __setitem__ for SubTensorDict #369

merged 3 commits into from
Aug 29, 2022

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Aug 19, 2022 •
edited
Loading

Description

Allows to write a parent tensors from a subtensordict in-pace using setitem.
See #368 for context

TODO:

  • Write a simple test for this

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2022
@vmoens vmoens mentioned this pull request Aug 19, 2022
Closed
3 tasks
@vmoens vmoens added bug Something isn't working enhancement New feature or request labels Aug 19, 2022
@vmoens vmoens merged commit c63d98b into main Aug 29, 2022
@vmoens vmoens deleted the subtd_inplace_setitem branch August 29, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot