Skip to content

[Doc] Add charts to examples #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 7, 2022
Merged

[Doc] Add charts to examples #374

merged 9 commits into from
Sep 7, 2022

Conversation

nicolas-dufour
Copy link
Contributor

@nicolas-dufour nicolas-dufour commented Aug 22, 2022 •
edited
Loading

Description

This PR adds performance charts to the examples README.

Motivation and Context

The motivation is to allow the reviewer to be able to have an idea of the performances of the library

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2022
@vmoens vmoens changed the title Add charts to examples [Doc] Add charts to examples Aug 24, 2022
@vmoens vmoens added the documentation Improvements or additions to documentation label Sep 6, 2022
vmoens
vmoens approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's a nice thing to have!
Thanks for taking care of it! It's catchy

Can you address the few comments? Happy to land then

@vmoens
Copy link
Collaborator

vmoens commented Sep 7, 2022

Can we change "Then, go to the directory that interests you and run" which sounds a bit frenchy to "Scripts can be run from the directory of interest using:"?

@vmoens vmoens merged commit de66dca into pytorch:main Sep 7, 2022
@nicolas-dufour nicolas-dufour deleted the ex_log_charts branch September 16, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-dufour @vmoens @facebook-github-bot