Skip to content

[Naming] Rename _TargetNetUpdate to TargetNetUpdater, making it public #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

[Naming] Rename _TargetNetUpdate to TargetNetUpdater, making it public #422

merged 1 commit into from
Sep 12, 2022

Conversation

yushiyangk
Copy link
Contributor

Description

Renamed _TargetNetUpdate to TargetNetUpdater in torchrl.objectives.costs.utils, making it a public class since it is imported by other classes for the purpose of type annotation.

Replaced all references to the above accordingly, including in docstrings.

Motivation and Context

Addresses #416

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot
Copy link

Hi @yushiyangk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vmoens vmoens changed the title Rename _TargetNetUpdate to TargetNetUpdater, making it public [Naming] Rename _TargetNetUpdate to TargetNetUpdater, making it public Sep 12, 2022
@vmoens vmoens added the naming Naming convention in the code label Sep 12, 2022
vmoens
vmoens approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

@vmoens vmoens marked this pull request as ready for review September 12, 2022 03:48
@vmoens vmoens merged commit 47906c6 into pytorch:main Sep 12, 2022
@vmoens vmoens mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
naming Naming convention in the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yushiyangk @facebook-github-bot @vmoens