Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] reorganize imports #545

Merged
merged 1 commit into from
Oct 10, 2022
Merged

[Lint] reorganize imports #545

merged 1 commit into from
Oct 10, 2022

Conversation

apbard
Copy link
Contributor

@apbard apbard commented Oct 10, 2022

reorganize imports

[Lint] reorganize imports
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2022
@vmoens vmoens added the quality code quality label Oct 10, 2022
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #545 (8f71072) into main (b2eb1b8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
- Coverage   86.74%   86.72%   -0.02%     
==========================================
  Files         121      121              
  Lines       21680    21671       -9     
==========================================
- Hits        18806    18795      -11     
- Misses       2874     2876       +2     
Flag Coverage Δ
linux-cpu 85.09% <100.00%> (-0.01%) ⬇️
linux-gpu 86.55% <100.00%> (-0.01%) ⬇️
linux-outdeps-gpu 77.85% <97.05%> (-0.01%) ⬇️
linux-stable-cpu 85.08% <100.00%> (-0.01%) ⬇️
linux-stable-gpu 86.55% <100.00%> (-0.01%) ⬇️
macos-cpu 84.85% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_functorch.py 94.33% <ø> (ø)
test/test_rb.py 96.76% <ø> (ø)
test/test_tensor_spec.py 99.51% <ø> (ø)
test/mocking_classes.py 96.35% <100.00%> (ø)
test/smoke_test.py 100.00% <100.00%> (ø)
test/test_collector.py 96.65% <100.00%> (-0.02%) ⬇️
test/test_cost.py 96.41% <100.00%> (ø)
test/test_distributions.py 98.40% <100.00%> (ø)
test/test_env.py 98.84% <100.00%> (ø)
test/test_exploration.py 98.84% <100.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vmoens vmoens merged commit 2f31613 into pytorch:main Oct 10, 2022
tcbegley pushed a commit to tcbegley/rl that referenced this pull request Oct 11, 2022
vmoens added a commit that referenced this pull request Oct 13, 2022
* [BugFix] Transformed ParallelEnv meta data are broken when passing to device (#531)

* [Doc] Add coverage banner (#533)

* add orb decov to circleci config.yml

* Add codecov badge to Readme

* Revert "[BugFix] Changing the dm_control import to fail if not installed (#515)"

This reverts commit d194735.

* codecov coverage w/o orb in circleci

* Revert "Revert "[BugFix] Changing the dm_control import to fail if not installed (#515)""

This reverts commit d0dc7de.

* [CI] generation of coverage reports (#534)

* update test scripts to add coverage

* update test scripts to add coverage

Co-authored-by: Silvestre Bahi <silvestrebahi@fb.com>

* [CI] Add xml coverage reports for codecov (#537)

* update test scripts to add coverage

* update test scripts to add coverage

* generate xml file for coverage

* Update run_test.sh

lint end of file

* Update run_test.sh

lint end of file

* Update run_test.sh

lint end of file

Co-authored-by: Silvestre Bahi <silvestrebahi@fb.com>

* permissions

* permissions

Co-authored-by: Silvestre Bahi <silvestrebahi@fb.com>
Co-authored-by: silvestrebahi <silvestre.bahi@gmail.com>

* [BugFix] Fix colab link of coding_dqn.ipynb (#543)

* [BugFix] Fix optional imports (#535)

* [BugFix] Restore missing keys in data collector output (#521)

* Ensure data collectors return all expected keys

* Rerun CI

* Add tests

* Format code

* correct unreachable test

* Fix broken test

* WIP: fix initialisation with policy + test

* Fix initialisation with policy + test

* Reset env after rollout initialisation

* fix build from spec

* Check policy has spec attribute before accessing

* Address comments

Co-authored-by: vmoens <vincentmoens@gmail.com>

* [Lint] reorganize imports (#545)

[Lint] reorganize imports

* [BugFix] Single-cpu compatibility (#548)

* [BugFix] vision install and other deps in optdeps (#552)

* init

* amend

* amend

* amend

* [Feature] Implemented device argument for modules.models (#524)

Co-authored-by: Yu Shiyang <yushiyang@fb.com>

* [BugFix] Fix ellipsis indexing of 2d TensorDicts (#559)

* [BugFix] Additive gaussian exploration spec fix (#560)

* [BugFix] Disabling video step for wandb (#561)

* [BugFix] Various device fix (#558)

* [Feature] Allow collectors to accept regular modules as policies (#546)

* [BugFix] Fix push binary nightly action (#566)

Fix Push Binary Nightly Action for linux hosts

Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
Co-authored-by: Silvestre Bahi <silvestrebahi@fb.com>
Co-authored-by: silvestrebahi <silvestre.bahi@gmail.com>
Co-authored-by: Bo Liu <benjaminliu.eecs@gmail.com>
Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Co-authored-by: Alessandro Pietro Bardelli <apbard@users.noreply.github.com>
Co-authored-by: Yu Shiyang <yushiyangk@users.noreply.github.com>
Co-authored-by: Yu Shiyang <yushiyang@fb.com>
Co-authored-by: Pavel Solikov <psolikov15@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants