Skip to content

Conversation

nikhlrao
Copy link
Contributor

Description

When a replay buffer is being created, the storage is printed on the log. This print being printed in alphabetical order was a nice to have and this change brings in that.

Motivation and Context

Close issue #508

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2022
@nikhlrao nikhlrao marked this pull request as ready for review October 16, 2022 21:49
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #573 (682be9d) into main (7edad2d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   86.96%   86.96%           
=======================================
  Files         121      121           
  Lines       21819    21819           
=======================================
  Hits        18975    18975           
  Misses       2844     2844           
Flag Coverage Δ
linux-cpu 85.29% <100.00%> (ø)
linux-gpu 86.74% <100.00%> (ø)
linux-outdeps-gpu 75.40% <100.00%> (ø)
linux-stable-cpu 85.27% <100.00%> (ø)
linux-stable-gpu 86.74% <100.00%> (ø)
macos-cpu 85.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchrl/data/replay_buffers/storages.py 90.26% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit bc26b99 into pytorch:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants