Add Torchdata as a requirement and remove conditional imports of Torchdata #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current failures are from the new Github actions we are adding for replacing CircleCI. Will ignore these for now. |
abhinavarora
added a commit
to abhinavarora/text
that referenced
this pull request
Oct 25, 2022
…hdata (pytorch#1961) * Add Torchdata as a requirement and remove conditional imports of Torchdata * Add torchdata dep to meta.yaml
Closed
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Oct 28, 2022
Summary: To support Python 3.10, we need to update a few model dependencies such as fairseq and spacy. We need to add torchaudio dependency because newer version of fairseq now depends on torchaudio: https://github.com/facebookresearch/fairseq/blob/main/setup.py#L190 Torchtext also adds new dependency torchdata so we need to include that as well: pytorch/text#1961 Currently, the CircleCI test runs on Python 3.8, and the GHA test runs on Python 3.10. Pull Request resolved: #1261 Reviewed By: desertfire Differential Revision: D40778986 Pulled By: xuzhao9 fbshipit-source-id: 897829f662ac4554ab7aee87c50a39c662269b21
gairgeio
added a commit
to gairgeio/benchmark
that referenced
this pull request
Aug 2, 2024
Summary: To support Python 3.10, we need to update a few model dependencies such as fairseq and spacy. We need to add torchaudio dependency because newer version of fairseq now depends on torchaudio: https://github.com/facebookresearch/fairseq/blob/main/setup.py#L190 Torchtext also adds new dependency torchdata so we need to include that as well: pytorch/text#1961 Currently, the CircleCI test runs on Python 3.8, and the GHA test runs on Python 3.10. Pull Request resolved: pytorch/benchmark#1261 Reviewed By: desertfire Differential Revision: D40778986 Pulled By: xuzhao9 fbshipit-source-id: 897829f662ac4554ab7aee87c50a39c662269b21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.