Migrate to enable Python 3.10 #1261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
desertfire
reviewed
Oct 28, 2022
| if self.device == "cuda": | ||
| current_device_name = torch.cuda.get_device_name() | ||
| assert current_device_name, f"torch.cuda.get_device_name() returns None when device is set to cuda, please double check." | ||
| elif self.device == "cpu": |
There was a problem hiding this comment.
Curious what is this change for?
There was a problem hiding this comment.
We now support specifying a smaller batch size for the CPU device. In the code, we try to use the same batch size as upstream. However, upstream batch sizes are often optimized for GPU, for CPU+inference tests, we want to use a smaller batch size by default to save test time.
desertfire
approved these changes
Oct 28, 2022
desertfire
approved these changes
Oct 28, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Python 3.10, we need to update a few model dependencies such as fairseq and spacy.
We need to add torchaudio dependency because newer version of fairseq now depends on torchaudio: https://github.com/facebookresearch/fairseq/blob/main/setup.py#L190
Torchtext also adds new dependency torchdata so we need to include that as well: pytorch/text#1961
Currently, the CircleCI test runs on Python 3.8, and the GHA test runs on Python 3.10.