Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate binaries for nightly/release testing #2010

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Dec 13, 2022

Uses https://github.com/pytorch/builder/blob/main/.github/workflows/validate-domain-library.yml workflow to validate torchtext on Linx, Windows, Macos, Macos arm64 OS's using existing smoke tests.

Implements nightly cron job to validate nighties

@atalman atalman marked this pull request as draft December 13, 2022 17:11
@atalman atalman changed the title [WIP] Validate linux binaries [WIP] Validate binaries Dec 17, 2022
@atalman atalman changed the title [WIP] Validate binaries Validate binaries for nightly/release testing Dec 19, 2022
@atalman atalman marked this pull request as ready for review December 19, 2022 21:53
Copy link
Contributor

@weiwangmeta weiwangmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@atalman atalman merged commit de368d7 into pytorch:main Dec 20, 2022
@joecummings joecummings mentioned this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants