Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote t5 and variants #2064

Merged
merged 10 commits into from
Feb 17, 2023
Merged

Conversation

joecummings
Copy link
Contributor

No description provided.

@@ -1 +1,2 @@
from .roberta import * # noqa: F401, F403
from .t5 import * # noqa: F401, F403
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t5 not added yet so this will cause errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's added in this commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH nvm u right

@@ -3,11 +3,12 @@
import pytest
import torch
from torchtext_unittest.common.torchtext_test_case import TorchtextTestCase
from torchtext_unittest.models.models_test_impl import BaseTestModels
from torchtext_unittest.models.roberta_models_test_impl import RobertaBaseTestModels
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this added?

@joecummings joecummings merged commit 670e52a into pytorch:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants