This repository was archived by the owner on Aug 1, 2025. It is now read-only.
[inductor] Fix alignment issue with new runtime #1412
Merged
+40
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add a test? |
I was trying to make a more minimal repro for this but having a hard time. Passing the wrong alignment hints to Triton don't always produce invalid code. |
ngimel
approved these changes
Sep 29, 2022
| if isinstance(arg, TensorArg) | ||
| or V.graph.sizevars.maybe_guard_multiple_of(arg.expr, JITFunction.divisibility) | ||
| ] | ||
| divisible_by_16 = [i for i, arg in enumerate(args) if is_aligned(arg)] |
There was a problem hiding this comment.
lol the place I worried about turned out to be problematic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue in #1338 that only shows up in one internal model.