This repository was archived by the owner on Aug 1, 2025. It is now read-only.
Fix list slice & ConstantVariable to TupleVariable conversion missing source info #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resubmit #222.
Fix #231, now
./torchbench.py -k yolov3
works well.ConstantVariable.call_method
wraps value asTupleVariable
and call itscall_method
, but doesn't propagate source info in this conversion, so the source chain is missed when codegen.torchbench
doesn't fail before Fix slicing list returning wrong result #222?As this can generate more concise code if the stack value is python constant compatible(only LOAD CONST in this case, and doesn't need to trace the source). I'd like to know if this is aligned with the design philosophy and update this PR if it makes sense.