Fix empty EmbeddingCollection/EmbeddingBagCollection edge cases #2823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71218553 |
joshuuuasu
added a commit
to joshuuuasu/torchrec
that referenced
this pull request
Mar 14, 2025
…rch#2823) Summary: This is an edge-case fix for D68991644. Some models include empty EmbeddingCollections or EmbeddingBagCollections by mistake (?), such as T217919588, thus causing the feature order caching logic broken. Differential Revision: D71218553
joshuuuasu
force-pushed
the
export-D71218553
branch
from
502818a to
e0e884c
Compare
…rch#2823) Summary: Pull Request resolved: pytorch#2823 This is an edge-case fix for D68991644. Some models include empty EmbeddingCollections or EmbeddingBagCollections by mistake (?), such as T217919588, thus causing the feature order caching logic broken. Differential Revision: D71218553
|
This pull request was exported from Phabricator. Differential Revision: D71218553 |
joshuuuasu
force-pushed
the
export-D71218553
branch
from
e0e884c to
f5ecb6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is an edge-case fix for D68991644. Some models include empty EmbeddingCollections or EmbeddingBagCollections by mistake (?), such as T217919588, thus causing the feature order caching logic broken.
Differential Revision: D71218553