jagged_tensor minor refactoring #2860
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56177133 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Mar 31, 2025
Summary: # context * move KT-related tests out from the test_jagged_tensor * use hypothesis.strategies to generate the test cases (the standard approach) * add some comments in jagged_tensor.py * use `torch.diff` to replace `_to_lengths` function. Reviewed By: ezyang Differential Revision: D56177133
TroyGarden
force-pushed
the
export-D56177133
branch
from
515d51c to
49200f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56177133 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Mar 31, 2025
Summary: # context * move KT-related tests out from the test_jagged_tensor * use hypothesis.strategies to generate the test cases (the standard approach) * add some comments in jagged_tensor.py * use `torch.diff` to replace `_to_lengths` function. Reviewed By: ezyang Differential Revision: D56177133
TroyGarden
force-pushed
the
export-D56177133
branch
from
49200f9 to
c5740e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56177133 |
Summary: # context * split test_jagged_tensor into multiple files to increase readability * use hypothesis.strategies to generate the test cases (the standard approach) * add some comments in jagged_tensor.py * use `torch.diff` to replace `_to_lengths` function. Reviewed By: ezyang, aporialiao Differential Revision: D56177133
TroyGarden
force-pushed
the
export-D56177133
branch
from
c5740e8 to
e839b87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56177133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
torch.diffto replace_to_lengthsfunction.Reviewed By: ezyang
Differential Revision: D56177133