Allows to configure flight recorder file prefix #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to configure flight recorder file prefix
meta-cla
bot
added
the
CLA Signed
fegin
commented
Sep 23, 2025
|
|
||
| TRACE_BUFFER_SIZE = "TORCH_FR_BUFFER_SIZE" | ||
| TRACE_FILE = "TORCH_NCCL_DEBUG_INFO_TEMP_FILE" | ||
| TRACE_FILE = "TORCH_FR_DUMP_TEMP_FILE" |
There was a problem hiding this comment.
TORCH_NCCL_DEBUG_INFO_TEMP_FILE is being deprecated
There was a problem hiding this comment.
I do think we should work on #1192
tianyu-l
approved these changes
Sep 23, 2025
|
|
||
| TRACE_BUFFER_SIZE = "TORCH_FR_BUFFER_SIZE" | ||
| TRACE_FILE = "TORCH_NCCL_DEBUG_INFO_TEMP_FILE" | ||
| TRACE_FILE = "TORCH_FR_DUMP_TEMP_FILE" |
There was a problem hiding this comment.
I do think we should work on #1192
Good point. We can address this issue after PTC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to configure flight recorder file prefix