Skip to content

add script to train with ft #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2025
Merged

add script to train with ft #1812

merged 2 commits into from
Oct 10, 2025

Conversation

tushar00jain
Copy link
Contributor

@tushar00jain tushar00jain commented Oct 7, 2025 •
edited
Loading

Summary:
the script adds configuration options to run training locally with ft enabled

Stack created with Sapling. Best reviewed with ReviewStack.

This was referenced Oct 7, 2025
Merged
Merged
Draft
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 7, 2025
@tushar00jain tushar00jain force-pushed the pr1812 branch 2 times, most recently from bd8c6c6 to ea4806e Compare October 7, 2025 21:54
wwwjn
wwwjn reviewed Oct 7, 2025
View reviewed changes
fegin
fegin requested changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Sapling makes reviewing hard. This PR basically contains everything from the previous PRs, same as the next one. It is very hard to understand what are the new pieces added by this and next PR.

@tushar00jain tushar00jain force-pushed the pr1812 branch 3 times, most recently from 6c39d25 to 6e6c41a Compare October 8, 2025 18:25
@tushar00jain
enhance profiler config
9e9890a 
Summary:
allow users to specify the profiler schedule
@tushar00jain tushar00jain force-pushed the pr1812 branch 2 times, most recently from 38b4b5d to 56004da Compare October 8, 2025 18:46
dcci
dcci reviewed Oct 8, 2025
View reviewed changes
@tushar00jain
add script to train with ft
54d2a8b 
Summary:
the script adds configuration options to run training locally with ft enabled
tushar00jain added a commit that referenced this pull request Oct 8, 2025
@tushar00jain
enhance profiler config (#1809)
21739fd 
Summary:
allow users to specify the profiler schedule

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1809).
* #1811
* #1810
* #1812
* __->__ #1809

Co-authored-by: Tushar Jain <tushar00jain@users.noreply.github.com>
@tushar00jain tushar00jain requested a review from fegin October 8, 2025 20:00
@tushar00jain tushar00jain mentioned this pull request Oct 8, 2025
Closed
tianyu-l
tianyu-l approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I think this torchft.md is created before the folder llama3_ft. For better proximity, we may consider putting part / all of this into llama3_ft/README.md. But not urgent and I don't have strong opinion.

@tushar00jain tushar00jain merged commit 42fe05f into pytorch:main Oct 10, 2025
8 checks passed
@tushar00jain tushar00jain deleted the pr1812 branch October 10, 2025 17:00
githubsgi pushed a commit to githubsgi/torchtitan that referenced this pull request Oct 13, 2025
@tushar00jain @githubsgi
enhance profiler config (pytorch#1809)
e7f4294 
Summary:
allow users to specify the profiler schedule

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1809).
* pytorch#1811
* pytorch#1810
* pytorch#1812
* __->__ pytorch#1809

Co-authored-by: Tushar Jain <tushar00jain@users.noreply.github.com>
githubsgi pushed a commit to githubsgi/torchtitan that referenced this pull request Oct 13, 2025
@tushar00jain @githubsgi
add script to train with ft (pytorch#1812)
f63037f 
Summary:
the script adds configuration options to run training locally with ft
enabled

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1812).
* pytorch#1840
* pytorch#1811
* pytorch#1810
* __->__ pytorch#1812
* pytorch#1809

---------

Co-authored-by: Tushar Jain <tushar00jain@users.noreply.github.com>
githubsgi pushed a commit to githubsgi/torchtitan that referenced this pull request Oct 15, 2025
@tushar00jain @githubsgi
add script to train with ft (pytorch#1812)
79c7690 
Summary:
the script adds configuration options to run training locally with ft
enabled

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1812).
* pytorch#1840
* pytorch#1811
* pytorch#1810
* __->__ pytorch#1812
* pytorch#1809

---------

Co-authored-by: Tushar Jain <tushar00jain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcci dcci dcci left review comments

@wwwjn wwwjn wwwjn left review comments

@fegin fegin fegin approved these changes

@tianyu-l tianyu-l tianyu-l approved these changes

@wconstab wconstab Awaiting requested review from wconstab wconstab is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tushar00jain @fegin @dcci @wwwjn @tianyu-l