add options to create_scheduler so that the get_runner method is full… #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
KPostOffice
force-pushed
the
pass-scheduler-args
branch
from
c3eeca5 to
ac577c0
Compare
…y configurable I also added a note to each schedulers __init__ method to help with maintainablility Signed-off-by: Kevin <kpostlet@redhat.com>
KPostOffice
force-pushed
the
pass-scheduler-args
branch
from
ac577c0 to
35218e7
Compare
Codecov Report
@@ Coverage Diff @@
## main #767 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 96 96
Lines 6096 6098 +2
=======================================
+ Hits 5662 5664 +2
Misses 434 434
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d4l3k
approved these changes
Sep 15, 2023
| ) | ||
|
|
||
| return RayScheduler(session_name=session_name) | ||
| return RayScheduler(session_name=session_name, ray_client=ray_client) |
There was a problem hiding this comment.
would be nice to add some unit tests for this
There was a problem hiding this comment.
I'll add some unit tests this week 👍🏻
Signed-off-by: Kevin <kpostlet@redhat.com>
KPostOffice
force-pushed
the
pass-scheduler-args
branch
from
67e318f to
509ced3
Compare
|
@d4l3k I've added those unit tests. Feel free to merge if you think the PR is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y configurable
I also added a note to each schedulers init method to help with maintainablility
I changed the create scheduler function for the local scheduler to specify the key word args that it takes rather than getting them from the
**kwargsdict.Test plan: