Skip to content

Unpin docstring-parser in requirements.txt #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Unpin docstring-parser in requirements.txt #772

merged 1 commit into from
Oct 4, 2023

Conversation

kiukchung
Copy link
Contributor

Resolves: #771

Test plan:

Ran unittests after upgrading docstring-parser to the latest (0.15)

$ pip uninstall docstring-parser
$ pip install -U -r requirements.txt
$ pip show docstring-parser
Name: docstring-parser
Version: 0.15
Summary: Parse Python docstrings in reST, Google and Numpydoc format
Home-page: https://github.com/rr-/docstring_parser
Author: Marcin Kurczewski
Author-email: dash@wind.garden
License: MIT
Location: /usr/local/google/home/kiuk/.pyenv/versions/3.10.12/envs/torchx_310/lib/python3.10/site-packages
Requires:
Required-by: kfp

$ pytest
<... TEST LOG OUTPUT OMITTED FOR BREVITY ...>
================================================================================================ 618 passed, 90 warnings in 90.51s (0:01:30) ================================================================================================

@kiukchung kiukchung requested a review from d4l3k October 4, 2023 19:41
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #772 (be8a5de) into main (d713116) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files          96       96           
  Lines        6098     6098           
=======================================
  Hits         5664     5664           
  Misses        434      434           
Flag Coverage Δ
unittests 92.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4l3k d4l3k merged commit 13a4787 into main Oct 4, 2023
@d4l3k d4l3k deleted the kiuk-dev branch October 4, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not pin docstring-parser to a fixed version
3 participants