Remove AppDef builder methods
#81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#80 Remove all builder methods from the ``Role`` class Differential Revision: D29168794 fbshipit-source-id: 50e16c1aa6c523241f980e59eee4ca3fde85cd48
Summary: The diff removes ``of``, ``get_metadata`` and ``add_metadata`` methods from the ``AppDef`` class Reviewed By: kiukchung Differential Revision: D29176342 fbshipit-source-id: 1ef98abb6d21b748bc5f7d58b59b1831d97e5a0e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D29176342 |
|
This pull request has been merged in d88972d. |
facebook-github-bot
pushed a commit
to pytorch/elastic
that referenced
this pull request
Jun 23, 2021
Summary: Pull Request resolved: pytorch/torchx#81 The diff removes ``of``, ``get_metadata`` and ``add_metadata`` methods from the ``AppDef`` class Reviewed By: kiukchung Differential Revision: D29176342 fbshipit-source-id: 99d1af4296f50213394980a5f9456c9b604aec7f
fotstrt
pushed a commit
to eth-easl/elastic
that referenced
this pull request
Feb 17, 2022
Summary: Pull Request resolved: pytorch/torchx#81 The diff removes ``of``, ``get_metadata`` and ``add_metadata`` methods from the ``AppDef`` class Reviewed By: kiukchung Differential Revision: D29176342 fbshipit-source-id: 99d1af4296f50213394980a5f9456c9b604aec7f
andrewjimpson9551
added a commit
to andrewjimpson9551/Elastic
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: pytorch/torchx#81 The diff removes ``of``, ``get_metadata`` and ``add_metadata`` methods from the ``AppDef`` class Reviewed By: kiukchung Differential Revision: D29176342 fbshipit-source-id: 99d1af4296f50213394980a5f9456c9b604aec7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The diff removes
of,get_metadataandadd_metadatamethods from theAppDefclassReviewed By: kiukchung
Differential Revision: D29176342