Skip to content

Fsdp advanced tutorial #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Jul 7, 2022
Merged

Conversation

HamidShojanazeri
Copy link
Contributor

This tutorial introduces, FSDP advanced features as updated in PT 1.12 release.

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 29caf67
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/62c67bfa518fc00008b7147c
😎 Deploy Preview https://deploy-preview-1959--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

HamidShojanazeri and others added 18 commits July 5, 2022 09:33
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! have some more comments

Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svekars svekars merged commit 0918023 into pytorch:master Jul 7, 2022
Copy link

@zhaojuanmao zhaojuanmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice tutorials, thanks!!

auto_wrap_policy=t5_auto_wrap_policy,
mixed_precision=bfSixteen,
device_id=torch.cuda.current_device(),
sharding_strategy=ShardingStrategy.SHARD_GRAD_OP # FULL_SHARD)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sharding_strategy=ShardingStrategy.SHARD_GRAD_OP # ZERO2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! This is fixed by #1969

@zhaojuanmao
Copy link

added one minor comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants