Skip to content

Fix the duplicated line in advanced_source/privateuseone.rst #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024

Conversation

shink
Copy link
Contributor

@shink shink commented Apr 30, 2024

Description

Fix the duplicated line in advanced_source/privateuseone.rst

 1. Register new backend module to Pytorch.
-2. Generate methods and properties related to the new backend.
+2. Rename PrivateUse1 to a custom name for the new backend.
 3. Generate methods and properties related to the new backend.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @svekars @brycebortree @albanD

Copy link

pytorch-bot bot commented Apr 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2853

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @shink!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@svekars svekars added core Tutorials of any level of difficulty related to the core pytorch functionality grammar and removed core Tutorials of any level of difficulty related to the core pytorch functionality labels Apr 30, 2024
@svekars
Copy link
Contributor

svekars commented Apr 30, 2024

The change looks good, can you please sign the CLA so we can merge? Thank you!

@shink
Copy link
Contributor Author

shink commented May 6, 2024

@svekars Sorry for the late reply. I have signed the CLA, please take a look, thanks!

@svekars svekars merged commit f748810 into pytorch:main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants