Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference to dcp in loading example #2972

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Fix reference to dcp in loading example #2972

merged 3 commits into from
Sep 5, 2024

Conversation

angerrp
Copy link
Contributor

@angerrp angerrp commented Jul 15, 2024 •
edited
Loading

Description

Imported as DCP but used as dcp. Changed import to dcp to have same import style as saving example.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @wconstab @osalpekar @H-Huang @kwen2501

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2972

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5e1833f with merge base 0e530ea (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angerrp angerrp changed the title Fix reference to DCP in lo Fix reference to DCP in loading example Jul 15, 2024
@svekars svekars requested review from LucasLLC and wz337 July 15, 2024 15:22
@angerrp angerrp changed the title Fix reference to DCP in loading example Fix reference to dcp in loading example Jul 17, 2024
wz337
wz337 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svekars svekars merged commit c2a8800 into pytorch:main Sep 5, 2024
18 checks passed
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
@angerrp @wz337 @c-p-i-o
Fix reference to dcp in loading example (#2972)
f8717d3 
* Fix reference to DCP
* Keep import style as saving

---------

Co-authored-by: Iris Z <31293777+wz337@users.noreply.github.com>
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
@angerrp @wz337 @c-p-i-o
Fix reference to dcp in loading example (#2972)
44493fb 
* Fix reference to DCP
* Keep import style as saving

---------

Co-authored-by: Iris Z <31293777+wz337@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz337 wz337 wz337 approved these changes

@LucasLLC LucasLLC Awaiting requested review from LucasLLC

Assignees
No one assigned
Labels
cla signed distributed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angerrp @wz337 @svekars @facebook-github-bot