Skip to content

Remove inferance from torchrec_intro_tutorial.py #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 10, 2025
Merged

Remove inferance from torchrec_intro_tutorial.py #3445

merged 6 commits into from
Jul 10, 2025

Conversation

isururanawaka
Copy link
Contributor

Address [T228334525]

  • Remove inference from torchrec_intro_tutorial.py
  • Pointed the main TorchRec tutorial for Inference.
  • Compliance with PyTorch Tutorial Audit - TorchRec Intro

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3445

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

svekars
svekars reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, torchrec tutorial is disabled: https://github.com/pytorch/tutorials/blob/main/.jenkins/validate_tutorials_built.py#L54. It would be great to remove it from the validate_tutorials_built.py and make it work. 1.1.0 version is used - do we need to update it and the fbgemm version?

@svekars svekars added the tutorials_audit used on tutorial audit PRs label Jul 10, 2025
@isururanawaka
Update validate_tutorials_built.py
fe58280 
remove entry "intermediate_source/torchrec_intro_tutorial",  from NOT_RUN
@isururanawaka
Update requirements.txt
96963b3 
Upgrade torchrec version to 1.2.0 from 1.1.0
@isururanawaka
Copy link
Contributor Author

@svekars enabled the tutorial and torchrec version is updated to 1.2.0

@svekars svekars merged commit ab48a0c into pytorch:main Jul 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

Assignees
No one assigned
Labels
cla signed tutorials_audit used on tutorial audit PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isururanawaka @svekars @facebook-github-bot