Skip to content

Conversation

mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Jan 3, 2020

No description provided.

@netlify
Copy link

netlify bot commented Jan 3, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 08acbc3

https://deploy-preview-807--pytorch-tutorials-preview.netlify.com

Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorials look great! I did a quick pass with some minor comments, and I will try to go through the tutorial + run the code in depth as well.

Copy link
Contributor Author

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add this to side bar index

@mrshenli
Copy link
Contributor Author

mrshenli commented Jan 3, 2020

Hey @jlin27 @SethHWeidman, may I get some early reviews on this tutorial page? Thanks!

@rohan-varma
Copy link
Contributor

General question: There is a model parallel tutorial that is essentially about sharding the model on the same node across many GPUs: https://deploy-preview-807--pytorch-tutorials-preview.netlify.com/intermediate/model_parallel_tutorial.html. Should we update the title or change it accordingly now that we have the ability to do model parallel across multiple nodes?

@rohan-varma
Copy link
Contributor

rohan-varma commented Jan 10, 2020

From running the code for the RL example, I don't think the args are defined? We can add something like this:

parser = argparse.ArgumentParser(
        description="RPC Reinforcement Learning Example",
        formatter_class=argparse.ArgumentDefaultsHelpFormatter,
    )

parser.add_argument('--world_size', default=2, help='Number of workers')
parser.add_argument('--log_interval', default=1, help='Log every log_interval episodes')
parser.add_argument('--gamma', default=0.1, help='how much to value future rewards')
parser.add_argument('--seed', default=1, help='random seed for reproducibility')
args = parser.parse_args()

Also, some variables aren't defined:

AGENT_NAME = "agent"
OBSERVER_NAME="obs"
TOTAL_EPISODE_STEP = 100

@mrshenli
Copy link
Contributor Author

Thanks @rohan-varma!

There is a model parallel tutorial that is essentially about sharding the model on the same node across many GPUs

Yes, let me edit the title and also mention the difference in this tutorial.

From running the code for the RL example, I don't think the args are defined? We can add something like this:

Thanks, those are in the examples, not in the tutorial, let me add them here too. Thank you!

@jlin27 jlin27 merged commit b4d26af into pytorch:master Jan 13, 2020
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants