-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Adding an RPC Tutorial #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for pytorch-tutorials-preview ready! Built with commit 08acbc3 https://deploy-preview-807--pytorch-tutorials-preview.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tutorials look great! I did a quick pass with some minor comments, and I will try to go through the tutorial + run the code in depth as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to add this to side bar index
Hey @jlin27 @SethHWeidman, may I get some early reviews on this tutorial page? Thanks! |
General question: There is a model parallel tutorial that is essentially about sharding the model on the same node across many GPUs: https://deploy-preview-807--pytorch-tutorials-preview.netlify.com/intermediate/model_parallel_tutorial.html. Should we update the title or change it accordingly now that we have the ability to do model parallel across multiple nodes? |
From running the code for the RL example, I don't think the
Also, some variables aren't defined:
|
Thanks @rohan-varma!
Yes, let me edit the title and also mention the difference in this tutorial.
Thanks, those are in the examples, not in the tutorial, let me add them here too. Thank you! |
Adding an RPC Tutorial
No description provided.