-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New classification datasets support for FLAVA #5108
Comments
I'm going to take DTD and Oxford Pets.
Nope. Downloads from Kaggle are currently not supported, since they require login. For now I would simply not add a
|
Can I try the Stanford cars dataset? |
I am taking the Food 101 now now. |
I was planning on taking the Stanford Cars dataset. @abhi-glitchhg if you're taking it, then I'll try the Food101 dataset |
Dang, I'm a few seconds late. I'll try PCAM then. |
I was planning on taking the Flowers-102. |
I am planning to take SUN dataset. |
I am planning to work on the GSTRB dataset. |
Coming late to the party, but I'd be keen to take care of EuroSAT 👍 |
@ everyone who volunteered to take a dataset: thanks a lot! @NicolasHug will be out until next year, so feel free to ping me on PRs. |
I'll take FGVC-Aircraft :) |
I'll take Country211 :) |
Addresses pytorch#5108. cc @pmeier @NicolasHug
* Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 31fadbe. * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 4e3d900. * Add Food101 Dataset Addresses #5108. cc @pmeier @NicolasHug * Remove unecessary Path contructor calls * Remove unecessary Path contructor callsi and fix types * Fix tests * Address PR comments from @pmeier * Fix bug in tests and in food101 dataset * Fix bug in tests and in food101 dataset * Update torchvision/datasets/food101.py Co-authored-by: Philip Meier <github.pmeier@posteo.de>
@oke-aditya Mind if I take the SUN dataset task, please ? |
Sure. Go ahead |
I would be grateful, if someone is also up to adding their dataset also for the upcoming new style of the datasets. I've just added #5133 that details how this should be done. So far no one besides the core team has worked on that so we are actively looking for feedback on the contributor experience. |
Summary: * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 31fadbe. * Adding multiweight support for shufflenetv2 prototype models * Revert "Adding multiweight support for shufflenetv2 prototype models" This reverts commit 4e3d900. * Add Food101 Dataset Addresses #5108. cc pmeier NicolasHug * Remove unecessary Path contructor calls * Remove unecessary Path contructor callsi and fix types * Fix tests * Address PR comments from pmeier * Fix bug in tests and in food101 dataset * Fix bug in tests and in food101 dataset * Update torchvision/datasets/food101.py Reviewed By: prabhat00155 Differential Revision: D33351107 fbshipit-source-id: de2a0df07397be82605ee5b700c96297ec3394d5 Co-authored-by: Philip Meier <github.pmeier@posteo.de>
To addresses issue pytorch#5108.
To addresses issue pytorch#5108.
Oh nice, I read about those prototypes and was curious to play around with it 😁 |
Exactly. Let me know if you hit any roadblocks as I'm eager to get feedback. |
Hello @zhiqwang 👋 |
Same for @fibbonnaci and the PCAM dataset. |
Hi @jdsgomes , I'm working on this now, and hope to submit the PR today. |
Thanks a lot of offering to help with the prototypes @frgfm . Let me know which one(s) you're trying to implement so we don't overlap :) . On my side I'll give try to GTSRB. |
Hey @fibbonnaci, PCAM is the last dataset that does not have a PR up yet. Are you working on that? If yes please push a PR even if you are not done, so we can help out and accelerate this. Otherwise, I'll send one myself. |
* Add Country211 dataset To addresses issue #5108. * Add Country211 dataset To addresses issue #5108. * Update country211.py * Update country211.py * Code review reflected Reflect code review * Update test_datasets.py * Update with review Update with review * inherit from ImageFolder * Update test/test_datasets.py * Docstring + minor test update Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
As discussed with @fibbonnaci offline, I'll take over the PCAM dataset. |
Summary: * Add Country211 dataset To addresses issue #5108. * Add Country211 dataset To addresses issue #5108. * Update country211.py * Update country211.py * Code review reflected Reflect code review * Update test_datasets.py * Update with review Update with review * inherit from ImageFolder * Update test/test_datasets.py * Docstring + minor test update Reviewed By: NicolasHug Differential Revision: D33618167 fbshipit-source-id: 04de3c5290b966ff97f21ea32b2f678079aa2a6c Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Nicolas Hug <nicolashug@fb.com>
Looks like we're all done Thank you so much everyone who submitted a dataset, your help is much appreciated! Tons of thanks to @pmeier in particular for all your help with submissions and the reviews!! |
To support our colleagues' work on the FLAVA paper, and to foster collaborations in the multi-modal space, we would like to implement a few new datasets. Almost all of them are classification datasets but some also support other tasks like segmentation.
target_type
parameter. @pmeier OxfordIIITPet dataset #5116(but maybe)@pmeier FER2013 dataset #5120CC-ing @pmeier and @jdsgomes as previously discussed. We're on a fairly short timeline for this work, and ideally we would get all these in by end of January 2022.
I'm also wondering whether this is something that our open source contributors @oke-aditya @frgfm @zhiqwang could be interested in 🚀 ?
Implementing a new dataset
Implementing a dataset consists of 2 main things:
root
,split
,transform
andtarget_transform
parameter. When available we should also support adownload
parameter (from what I checked, most of these are download-able apart maybe FER2013). See e.g. the MNIST classIf there's some ambiguity in the choices to make, the reference to follow is the VISSL where most of these datasets are already supported.
For contritbutors
If you're interesting in taking one of the datasets above, please comment below with "I'm working on dataset X" so that others don't pick the same! :)
cc @pmeier
The text was updated successfully, but these errors were encountered: