Building docs with `make html-noplot` ignores sphinx options

[pmeier]

The command currently looks like this:

vision/docs/Makefile

Lines 26 to 27 in 97eddc5

	html-noplot: # Avoids running the gallery examples, which may take time
	$(SPHINXBUILD) -D plot_gallery=0 -b html $(ASPHINXOPTS) "${SOURCEDIR}" "$(BUILDDIR)"/html

Not that ASPHINXOPTS is non-existent and thus we build without any options. Replacing this with SPHINXOPTS

vision/docs/Makefile

Line 9 in 97eddc5

SPHINXOPTS = -W -j auto $(EXAMPLES_PATTERN_OPTS)

leads to a warning of sphinx gallery (see sphinx-gallery/sphinx-gallery#913) which in turn stops the build in its tracks through our -W usage.

If we don't want these options for html-noplot, I suggest we remove the ASPHINXOPTS substitution. Otherwise, we should probably wait for them to fix this.

[NicolasHug]

I think I made a typo with this ASPHINXOPTS, happy to remove.

A temporary workaround to have a fast build while still erroring on warnings is to do

EXAMPLES_PATTERN="transforms" make html

which will just build the transforms example, causing the images to be present and removing the offending warning.

But the CI will build with the plots as a last resort.

[pmeier]

I think I made a typo with this ASPHINXOPTS, happy to remove.

Remove $(ASPHINXOPTS) or remove the A?

[NicolasHug]

remove ASPHINXOPTS