Skip to content

Conversation

tomas1808
Copy link
Contributor

@tomas1808 tomas1808 commented Jun 9, 2019

Changes made in 7716aba broke calls to this method. Extraction of Caltech, CIFAR10, Omniglot and STL10 were failing as a result.

@codecov-io
Copy link

codecov-io commented Jun 9, 2019

Codecov Report

Merging #1006 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
+ Coverage   62.63%   62.69%   +0.05%     
==========================================
  Files          65       65              
  Lines        5101     5101              
  Branches      765      765              
==========================================
+ Hits         3195     3198       +3     
+ Misses       1683     1681       -2     
+ Partials      223      222       -1
Impacted Files Coverage Δ
torchvision/datasets/caltech.py 20.65% <ø> (ø) ⬆️
torchvision/datasets/omniglot.py 32% <0%> (ø) ⬆️
torchvision/datasets/cifar.py 38.2% <0%> (ø) ⬆️
torchvision/datasets/stl10.py 26.59% <0%> (ø) ⬆️
torchvision/transforms/transforms.py 82.54% <0%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a64dbc...19ae7ac. Read the comment docs.

Changes made in 7716aba broke calls to this method.
@tomas1808 tomas1808 changed the title Fix call to 'download_and_extract_archive()' Fix calls to 'download_and_extract_archive()' Jun 9, 2019
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching this and fixing it!

We definitely need tests for Cifar and the other datasets!

@fmassa fmassa merged commit 394de98 into pytorch:master Jun 11, 2019
@pmeier pmeier mentioned this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants