Skip to content

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 7, 2019

Following a similar line of inquiry to pytorch/audio#217

@peterjc123 I haven't ported the Windows bits to the new infrastructure yet. If I have time later I'll look into it; I'm interested in whether or not we can reasonable do the Windows on CircleCI (so there's only one pipeline we have to look at.)

ezyang added 2 commits August 6, 2019 21:29
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@ezyang ezyang requested review from fmassa and soumith August 7, 2019 04:42
@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #1209 into master will decrease coverage by 0.39%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1209     +/-   ##
=========================================
- Coverage   65.58%   65.19%   -0.4%     
=========================================
  Files          74       74             
  Lines        5780     5784      +4     
  Branches      883      786     -97     
=========================================
- Hits         3791     3771     -20     
- Misses       1724     1739     +15     
- Partials      265      274      +9
Impacted Files Coverage Δ
torchvision/datasets/utils.py 59.35% <0%> (-1.3%) ⬇️
torchvision/io/video.py 71.31% <37.5%> (-0.69%) ⬇️
torchvision/datasets/cifar.py 71.26% <0%> (-6.9%) ⬇️
torchvision/datasets/folder.py 79.48% <0%> (-2.57%) ⬇️
torchvision/datasets/voc.py 20.87% <0%> (-2.2%) ⬇️
torchvision/datasets/lsun.py 20.83% <0%> (-2.09%) ⬇️
torchvision/transforms/transforms.py 79.76% <0%> (-1.18%) ⬇️
torchvision/transforms/functional.py 70.52% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c1609...5557cf6. Read the comment docs.

@peterjc123
Copy link
Contributor

peterjc123 commented Aug 7, 2019

@ezyang That's not possible since CircleCI doesn't support Windows.
Update: Looks like there is early access for Windows: https://discuss.circleci.com/t/windows-early-access-now-available-on-circleci/30977

@ezyang
Copy link
Contributor Author

ezyang commented Aug 7, 2019

@peterjc123 Yep. I should be able to get us expedited though.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@ezyang
Copy link
Contributor Author

ezyang commented Aug 7, 2019

@peterjc123 OK, Windows CPU is enabled. Docs are at https://circleci.com/docs/2.0/hello-world-windows/

ezyang added 5 commits August 7, 2019 07:02
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but I have a few questions regarding a few changes.

Also, I didn't check the new circle ci config very closely.

@ezyang
Copy link
Contributor Author

ezyang commented Aug 7, 2019

@peterjc123 I'm leaving some of the old files around so maybe the Windows pipeline keeps working; I don't know how to test it, if you let me know I can try and fix it as well for the file changes

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@ezyang ezyang merged commit 64ccfe3 into master Aug 7, 2019
@fmassa fmassa deleted the pr/packaging-rewrite branch August 7, 2019 17:38
ezyang added a commit that referenced this pull request Aug 7, 2019
Following a similar line of inquiry to pytorch/audio#217
ezyang added a commit that referenced this pull request Aug 8, 2019
* Rewrite torchvision packaging (#1209)

Following a similar line of inquiry to pytorch/audio#217

* Packaging fixes (#1214)

Add uploading support, make CUDA builds actually work.

* 0.4.0 parameters

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Actually upload wheels (please port to master)

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Put macos binaries in the right place

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Propagate more environment variables.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Change the version number

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

* Go time

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants