-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Rewrite torchvision packaging #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
=========================================
- Coverage 65.58% 65.19% -0.4%
=========================================
Files 74 74
Lines 5780 5784 +4
Branches 883 786 -97
=========================================
- Hits 3791 3771 -20
- Misses 1724 1739 +15
- Partials 265 274 +9
Continue to review full report at Codecov.
|
@ezyang That's not possible since CircleCI doesn't support Windows. |
@peterjc123 Yep. I should be able to get us expedited though. |
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
@peterjc123 OK, Windows CPU is enabled. Docs are at https://circleci.com/docs/2.0/hello-world-windows/ |
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this, but I have a few questions regarding a few changes.
Also, I didn't check the new circle ci config very closely.
@peterjc123 I'm leaving some of the old files around so maybe the Windows pipeline keeps working; I don't know how to test it, if you let me know I can try and fix it as well for the file changes |
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Following a similar line of inquiry to pytorch/audio#217
* Rewrite torchvision packaging (#1209) Following a similar line of inquiry to pytorch/audio#217 * Packaging fixes (#1214) Add uploading support, make CUDA builds actually work. * 0.4.0 parameters Signed-off-by: Edward Z. Yang <ezyang@fb.com> * Actually upload wheels (please port to master) Signed-off-by: Edward Z. Yang <ezyang@fb.com> * Put macos binaries in the right place Signed-off-by: Edward Z. Yang <ezyang@fb.com> * Propagate more environment variables. Signed-off-by: Edward Z. Yang <ezyang@fb.com> * Change the version number Signed-off-by: Edward Z. Yang <ezyang@fb.com> * Go time Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Following a similar line of inquiry to pytorch/audio#217
@peterjc123 I haven't ported the Windows bits to the new infrastructure yet. If I have time later I'll look into it; I'm interested in whether or not we can reasonable do the Windows on CircleCI (so there's only one pipeline we have to look at.)