Skip to content

Conversation

joaqo
Copy link
Contributor

@joaqo joaqo commented Aug 14, 2019

The number of workers default is set to 4, while the help string says it's 16. Not sure if the default was supposed to be 4 and its the help string that is actually incorrect tough.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The default argument is correct, but the comment is wrong.
Can you change the comment instead?

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #1243 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
+ Coverage   65.56%   65.64%   +0.08%     
==========================================
  Files          74       74              
  Lines        5784     5784              
  Branches      884      884              
==========================================
+ Hits         3792     3797       +5     
+ Misses       1726     1723       -3     
+ Partials      266      264       -2
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 81.53% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bceaf...1ba9177. Read the comment docs.

@joaqo
Copy link
Contributor Author

joaqo commented Aug 28, 2019

There you go!

@joaqo
Copy link
Contributor Author

joaqo commented Aug 28, 2019

(Squashed the two commits)

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 80cfc2c into pytorch:master Aug 29, 2019
@fmassa fmassa changed the title Fix small inconsistency in default argument Fix help message for num_workers in references/detection Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants