Add pad_value argument to make_grid and save_image #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
reviewed
Apr 5, 2017
torchvision/utils.py
Outdated
|
|
||
|
|
||
| def make_grid(tensor, nrow=8, padding=2, | ||
| def make_grid(tensor, nrow=8, padding=2, pad_value=0, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
requested changes
Apr 6, 2017
torchvision/utils.py
Outdated
|
|
||
|
|
||
| def make_grid(tensor, nrow=8, padding=2, | ||
| def make_grid(tensor, nrow=8, padding=2, pad_value=0, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Could you also add the new parameter to |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful, especially because 2 month ago the default color for padded pixels was white, while now I see black borders by default and cannot change it.