test: Updated assert in test_transforms #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated all raw asserts to corresponding unittest.TestCase.assert. See pytorch#1483
surgan12
reviewed
Oct 17, 2019
test/test_transforms.py
Outdated
| i, j, h, w = randresizecrop.get_params(img, scale_range, aspect_ratio_range) | ||
| aspect_ratio_obtained = w / h | ||
| assert (min(aspect_ratio_range) - epsilon <= aspect_ratio_obtained <= max(aspect_ratio_range) + epsilon or | ||
| self.assertTrue(min(aspect_ratio_range) - epsilon <= aspect_ratio_obtained <= max(aspect_ratio_range) + epsilon or |
There was a problem hiding this comment.
It seems lint is failing here due to long line. Could you just check it
ekagra-ranjan
suggested changes
Oct 17, 2019
There was a problem hiding this comment.
The lint is failing here too:
./test/test_transforms.py:1131:17: E128 continuation line under-indented for visual indent
./test/test_transforms.py:1131:66: E502 the backslash is redundant between brackets
./test/test_transforms.py:1132:17: E128 continuation line under-indented for visual indent```
|
Thanks for the feedback @surgan12 @ekagra-ranjan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all raw
assertto the correspondingunittest.TestCaseassert method for tests related to torchvision.transforms as suggested by #1483.The specific test was run locally with success, any feedback is welcome!