Correctness test implemented with old test architecture #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmassa I don't have perms to kick off another test run, but it looks like the few remaining errors are a 500 on the CI server, unrelated to my code. |
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
=======================================
Coverage 64.34% 64.34%
=======================================
Files 83 83
Lines 6454 6454
Branches 992 992
=======================================
Hits 4153 4153
Misses 2006 2006
Partials 295 295Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds correctness checks for classification models. Expected values for the models are in the expect/ folder.