Removed Redundant Code in Video Classification Training Script (Kinetics400 Constructor)
#1549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsomani95
changed the title
Kinetics400 Constructor)Kinetics400 Constructor)
Codecov Report
@@ Coverage Diff @@
## master #1549 +/- ##
=======================================
Coverage 65.49% 65.49%
=======================================
Files 90 90
Lines 7078 7078
Branches 1076 1076
=======================================
Hits 4636 4636
Misses 2134 2134
Partials 308 308Continue to review full report at Codecov.
|
|
Happy to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both the training and testing datasets, there was some code being called after constructing the datasets which made some changes to the dataset internally. With this PR, those changes are made while first constructing the dataset.
I've demonstrated this in more detail in this Jupyter notebook.