Skip to content

Conversation

lara-hdr
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #1593 into master will decrease coverage by 0.3%.
The diff coverage is 28.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1593      +/-   ##
==========================================
- Coverage   65.96%   65.65%   -0.31%     
==========================================
  Files          90       90              
  Lines        7049     7085      +36     
  Branches     1071     1075       +4     
==========================================
+ Hits         4650     4652       +2     
- Misses       2094     2126      +32     
- Partials      305      307       +2
Impacted Files Coverage Δ
torchvision/models/detection/roi_heads.py 51.13% <27.27%> (-3.51%) ⬇️
torchvision/models/detection/transform.py 79.06% <33.33%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aec85d...aa4e409. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Lara!

It looks good, thanks a lot!

There is one change that I think wasn't intended, can you check it?

@fmassa fmassa merged commit b8e3e96 into pytorch:master Nov 21, 2019
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Nov 21, 2019
* code changes to enable onnx export for keypoint rcnn

* add import

* fix copy paste error
facebook-github-bot pushed a commit that referenced this pull request Nov 27, 2019
Summary:
* code changes to enable onnx export for keypoint rcnn

* add import

* fix copy paste error
Pull Request resolved: #1603

Reviewed By: zhangguanheng66

Differential Revision: D18638672

Pulled By: fmassa

fbshipit-source-id: c3a7cb18f35e48e9e10a7b6550cfb73e53385ea4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants