Skip to content

Conversation

moskomule
Copy link
Contributor

@moskomule moskomule commented Jun 11, 2017

enabled ~ expression in datasets, e.g.

datasets.MNIST('~/.torch/data/mnist', train=True, download=True,...)

will save data in /home/USER_NAME/.torch/data/mnist instead of current CURRENT_DIR/~/.torch/data/mnist.


It's my first pull request ever, so if something wrong or something insufficient, let me know. Thank you.

@fmassa
Copy link
Member

fmassa commented Jun 13, 2017

Hi,
Thanks for the PR!

I have one concern about os.path.expanduser: it seems that it is broken for python 2.7 for Windows when you have unicode characters in the path.
For that reason, I think it would be better not to merge this PR, given that it could break user code once we get PyTorch Windows-compatible.

Any thoughts on that?

@soumith
Copy link
Member

soumith commented Jun 13, 2017

we will not be supporting python 2.7 on windows. We will only be supporting py3+, so not a problem.

@soumith soumith merged commit c1f88ef into pytorch:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants