Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 26, 2020

Closes #2015

@pmeier pmeier marked this pull request as ready for review March 26, 2020 14:44
@pmeier
Copy link
Collaborator Author

pmeier commented Mar 26, 2020

@fmassa I did not include it in this PR, but do you want me to remove

if sys.version_info[0] == 2:
import xml.etree.cElementTree as ET
else:
import xml.etree.ElementTree as ET

and the like in a follow up PR?

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @pmeier !

I have a comment about str and bytes, let me know what you think. Apart from that, the PR looks good to go

@fmassa
Copy link
Member

fmassa commented Mar 30, 2020

I did not include it in this PR, but do you want me to remove

yes, please, if you could remove the cElementTree in a follow-up PR it would be great!

@codecov-io
Copy link

codecov-io commented Mar 31, 2020

Codecov Report

Merging #2017 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2017      +/-   ##
=========================================
+ Coverage    0.48%   0.48%   +<.01%     
=========================================
  Files          92      92              
  Lines        7449    7447       -2     
  Branches     1135    1135              
=========================================
  Hits           36      36              
+ Misses       7400    7398       -2     
  Partials       13      13
Impacted Files Coverage Δ
torchvision/datasets/sbu.py 0% <ø> (ø) ⬆️
torchvision/datasets/flickr.py 0% <0%> (ø) ⬆️
torchvision/datasets/mnist.py 0% <0%> (ø) ⬆️
torchvision/datasets/lsun.py 0% <0%> (ø) ⬆️
torchvision/datasets/utils.py 0% <0%> (ø) ⬆️
torchvision/transforms/transforms.py 0% <0%> (ø) ⬆️
torchvision/datasets/vision.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c254fb...f6c6dbc. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pmeier!

@fmassa fmassa merged commit 42b8d46 into pytorch:master Mar 31, 2020
@pmeier pmeier deleted the remove_six branch March 31, 2020 18:43
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Jul 8, 2020
* remove six from python code

* remove six from setup.py

* remove six from tests

* remove six from references

* remove six from packaging

* revert str to torch._six._string_classes

* revert str to torch._six._string_classes
facebook-github-bot pushed a commit that referenced this pull request Jul 8, 2020
Summary:
* remove six from python code

* remove six from setup.py

* remove six from tests

* remove six from references

* remove six from packaging

* revert str to torch._six._string_classes

* revert str to torch._six._string_classes

Pull Request resolved: #2410

Reviewed By: zhangguanheng66

Differential Revision: D22432521

Pulled By: fmassa

fbshipit-source-id: 9fa1dcfb9c5da0bbd6d62a07fbcb268e264cd562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove six dependency
3 participants