-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Remove six dependency #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove six dependency #2017
Conversation
@fmassa I did not include it in this PR, but do you want me to remove vision/torchvision/datasets/voc.py Lines 7 to 10 in 3c254fb
and the like in a follow up PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @pmeier !
I have a comment about str
and bytes
, let me know what you think. Apart from that, the PR looks good to go
yes, please, if you could remove the |
Codecov Report
@@ Coverage Diff @@
## master #2017 +/- ##
=========================================
+ Coverage 0.48% 0.48% +<.01%
=========================================
Files 92 92
Lines 7449 7447 -2
Branches 1135 1135
=========================================
Hits 36 36
+ Misses 7400 7398 -2
Partials 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @pmeier!
* remove six from python code * remove six from setup.py * remove six from tests * remove six from references * remove six from packaging * revert str to torch._six._string_classes * revert str to torch._six._string_classes
Summary: * remove six from python code * remove six from setup.py * remove six from tests * remove six from references * remove six from packaging * revert str to torch._six._string_classes * revert str to torch._six._string_classes Pull Request resolved: #2410 Reviewed By: zhangguanheng66 Differential Revision: D22432521 Pulled By: fmassa fbshipit-source-id: 9fa1dcfb9c5da0bbd6d62a07fbcb268e264cd562
Closes #2015