Skip to content

[Cherry-pick for 0.7] Fix torchhub due to numerical changes in torch.sum (#2361) #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020
Merged

[Cherry-pick for 0.7] Fix torchhub due to numerical changes in torch.sum (#2361) #2364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions test/test_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def sum_of_model_parameters(model):
return s


SUM_OF_PRETRAINED_RESNET18_PARAMS = -12703.99609375
SUM_OF_PRETRAINED_RESNET18_PARAMS = -12703.9931640625


@unittest.skipIf('torchvision' in sys.modules,
Expand All @@ -31,8 +31,9 @@ def test_load_from_github(self):
'resnet18',
pretrained=True,
progress=False)
self.assertEqual(sum_of_model_parameters(hub_model).item(),
SUM_OF_PRETRAINED_RESNET18_PARAMS)
self.assertAlmostEqual(sum_of_model_parameters(hub_model).item(),
SUM_OF_PRETRAINED_RESNET18_PARAMS,
places=2)

def test_set_dir(self):
temp_dir = tempfile.gettempdir()
Expand All @@ -42,8 +43,9 @@ def test_set_dir(self):
'resnet18',
pretrained=True,
progress=False)
self.assertEqual(sum_of_model_parameters(hub_model).item(),
SUM_OF_PRETRAINED_RESNET18_PARAMS)
self.assertAlmostEqual(sum_of_model_parameters(hub_model).item(),
SUM_OF_PRETRAINED_RESNET18_PARAMS,
places=2)
self.assertTrue(os.path.exists(temp_dir + '/pytorch_vision_master'))
shutil.rmtree(temp_dir + '/pytorch_vision_master')

Expand Down