-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Add RPATH to torchvision cmake target for torch libraries #2801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bmanga I checked this PR with the test from #2807 on MacOSX. The example works on the current master and on this PR giving 9 ops. The only difference is with linked libraries:
and
|
@vfdev-5 Thanks for checking. Given that it seems to work fine also on osx, do you think it's fine to merge? I am not sure what is going on with the tests, but it doesn't seem to work for me locally without this change (I get a runtime error saying that the libtorch libraries could not be found). |
@bmanga I updated the PR to current master, so let's see what CI shows (we can skip Travis as it is broken now) and see if possible to merge like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge. Travis failure is unrelated.
Thanks @bmanga !
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
=======================================
Coverage 73.36% 73.36%
=======================================
Files 99 99
Lines 8787 8787
Branches 1387 1387
=======================================
Hits 6447 6447
Misses 1916 1916
Partials 424 424 Continue to review full report at Codecov.
|
Co-authored-by: vfdev <vfdev.5@gmail.com>
Co-authored-by: vfdev <vfdev.5@gmail.com>
This adds the RPATH to the torch libraries so that they can be found when a project links to torchvision