[release/0.8] .cirlceci: Be specific about CU_VERSION for pytorch #2826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROCM builds were being picked up for CUDA 10.2 builds since they do not specify a version suffix. We can utilize the CU_VERSION to be specific about which index to actually pull from. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
changed the title
fmassa
approved these changes
Oct 16, 2020
We actually do provide ROCM binaries already for nightlies, so I'm not entirely sure why this didn't present itself in the nightlies, but in any case this'll get us unblocked for today. #2827 is the version of this PR for |
|
Test failures only apply to the new |
|
Checks have passed the area they failed previously so going to go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROCM builds were being picked up for CUDA 10.2 builds since they do not
specify a version suffix. We can utilize the CU_VERSION to be specific
about which index to actually pull from.
Logs of what happened during the release: https://app.circleci.com/pipelines/github/pytorch/vision/4454/workflows/efcd7fa9-7f94-46ef-bee3-a70cefd2dcd2/jobs/266058
Signed-off-by: Eli Uriegas eliuriegas@fb.com