make_grid should not avoid DBZ by adding eps #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this doesn't matter in most cases where the images is quantized to [0,255] afterwards, it still is not a faithful de-normalization. It is a simple change to make it use clamp instead.
|
@ssnl thanks for the PR. Seems like related tests are failing: https://app.circleci.com/pipelines/github/pytorch/vision/4909/workflows/a919c232-bf9d-4125-a296-61154c5851f1/jobs/300230 |
|
Time for changing the |
Codecov Report
@@ Coverage Diff @@
## master #2967 +/- ##
==========================================
+ Coverage 73.43% 74.05% +0.61%
==========================================
Files 99 99
Lines 8813 9076 +263
Branches 1391 1448 +57
==========================================
+ Hits 6472 6721 +249
- Misses 1916 1922 +6
- Partials 425 433 +8
Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* make_grid should not avoid DBZ by adding eps While this doesn't matter in most cases where the images is quantized to [0,255] afterwards, it still is not a faithful de-normalization. It is a simple change to make it use clamp instead. * fix max/min shadowing
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* make_grid should not avoid DBZ by adding eps While this doesn't matter in most cases where the images is quantized to [0,255] afterwards, it still is not a faithful de-normalization. It is a simple change to make it use clamp instead. * fix max/min shadowing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this doesn't matter in most cases where the image is quantized to [0,255] afterwards, it still is not a faithful de-normalization. It is a simple change to make it use clamp instead.