Make read_file and write_file accept unicode strings on Windows (#2949) #3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch#2949) * Make read_file accept unicode strings on Windows * More fixes * Remove definitions from source files * Move string definitions to header * Add checks * Fix comments * Update macro * Fix comments * Fix lint * include windows header * Change func signature in header * Use from_blob * Fix fread calls * Fix clang format * Fix missing return * Avoid copy
|
@fmassa Actually we are also fixing the |
|
@peterjc123 Given that the branch freeze for the 1.7.1 release of PyTorch is tomorrow, I believe it's better to have this patch merged in for the dot release, and then for the 1.8.0 release of PyTorch we revert back to using |
peterjc123
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for the 0.8.3 release
cc @seemethere