Refactors test_image.py so tests don't write files to assets folder #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
reviewed
Nov 18, 2020
There was a problem hiding this comment.
Thanks for the PR! I left a few comments for your consideration. Let me know what you think.
Also you got conflicts with master due to my previous PR (#2988). Let me know if you need any help resolving the conflicts, happy to help.
datumbox
approved these changes
Nov 30, 2020
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
…ytorch#3018) * Fix writing to files by using get_tmp_dir() * Add ImageReadMode to imports * Fix failing test due to incorrect image path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically fixes #3002 and makes some parts of code more readable. We could probably do something similar for other tests that rely on
get_tmp_dir()just by using what's done here, i.e.setUpClass(),tearDown(), andtearDownClass()Edit: After code review I changed it to use
get_tmp_dir()instead ofsetUpClass(),tearDown(), andtearDownClass()