Skip to content

Adapt to new pytorch onnx exporter API for dictionary #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2020
Merged

Adapt to new pytorch onnx exporter API for dictionary #3160

merged 3 commits into from
Dec 12, 2020

Conversation

jiafatom
Copy link
Contributor

The PR is merged at 12:31 pm on 12/10/2020 (yesterday) which uses a new API if the last input is a dictionary -- It need add a dummy dictionary input at the end.
This API change breaks the torch vision test, and here we fix the test.

Other minor:
We update to use stable version of onnxruntime, because test.pypi removes old ort-nightly periodically.

@jiafatom jiafatom mentioned this pull request Dec 11, 2020
Merged
@jiafatom
Copy link
Contributor Author

The cmake_windows_cpu CI failure is about:

Writing SSH key for checkout to id_rsa
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Error setting git remote: exit status 128

which seems unrelated to this PR.

@datumbox
Copy link
Contributor

@jiafatom Indeed this seems unrelated and possibly fixes the issue. I restarted the CI and if it passes I'm going to merge.Thanks for responding so quickly and fixing the issue.

@codecov
Copy link

codecov bot commented Dec 12, 2020 •
edited
Loading

Codecov Report

Merging #3160 (f6d0f08) into master (0963ff7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3160   +/-   ##
=======================================
  Coverage   72.79%   72.79%           
=======================================
  Files          98       98           
  Lines        8964     8964           
  Branches     1430     1430           
=======================================
  Hits         6525     6525           
  Misses       1992     1992           
  Partials      447      447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0963ff7...f6d0f08. Read the comment docs.

@datumbox datumbox merged commit 2e5e058 into pytorch:master Dec 12, 2020
@jiafatom jiafatom deleted the onnx_dict branch December 12, 2020 00:55
@zhiqwang zhiqwang mentioned this pull request Dec 12, 2020
Merged
@datumbox datumbox self-requested a review December 12, 2020 10:47
facebook-github-bot pushed a commit that referenced this pull request Dec 15, 2020
@fmassa @facebook-github-bot
Adapt to new pytorch onnx exporter API for dictionary (#3160)
736747e 
Summary: * Adapt to new torch export API for dictionary

Reviewed By: datumbox

Differential Revision: D25531037

fbshipit-source-id: 123002753d63aee9feaafcafb077c80af1652331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datumbox datumbox Awaiting requested review from datumbox

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiafatom @datumbox @facebook-github-bot