Replace hardcoded error code with ENODATA #3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The video reader suppressed code 61 (ENODATA on Linux) that occured at the end of a stream and logged an INFO message. On macOS ENODATA has a different code (96), which resulted in an error message being logged. This small patch replaces the hard-coded value with the ENODATA constant to suppress the macOS warning.
|
Looks good to me; LGTM if there are no test failures |
Looks like there are some failing tests in master, that are also failing here. |
Don't worry these are not from your commit. :) |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
Summary: The video reader suppressed code 61 (ENODATA on Linux) that occured at the end of a stream and logged an INFO message. On macOS ENODATA has a different code (96), which resulted in an error message being logged. This small patch replaces the hard-coded value with the ENODATA constant to suppress the macOS warning. Reviewed By: datumbox Differential Revision: D26156366 fbshipit-source-id: 6424c96c4d836a89dc3c4025062bf21d0f5e48c9 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The video reader suppressed code 61 (
ENODATAon Linux) that occured at the end of a stream and logged anINFOmessage. On macOSENODATAhas a different code (96), which resulted in an error message being logged.This small patch replaces the hard-coded value with the
ENODATAconstant to suppress the macOS error.Fixes #3274