Skip to content

Remove python3.5 typing dependency #3288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2021
Merged

Remove python3.5 typing dependency #3288

merged 2 commits into from
Jan 25, 2021

Conversation

datumbox
Copy link
Contributor

Removing old code from packaging files that handled typing dependencies for Python 3.5.

@datumbox datumbox requested a review from fmassa January 25, 2021 00:46
fmassa
fmassa approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 05c5425 into pytorch:master Jan 25, 2021
@datumbox datumbox deleted the ci/remove_py3.5 branch January 25, 2021 09:37
facebook-github-bot pushed a commit that referenced this pull request Feb 1, 2021
@vincentqb @facebook-github-bot
Remove python3.5 typing dependency. (#3288)
cc4cfe3 
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Reviewed By: datumbox

Differential Revision: D26156368

fbshipit-source-id: bbabef6d95f7bc8ca350d636676243b64e61a5b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
cla signed module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @fmassa @facebook-github-bot